Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA Metro: Removing time as a necessity for partnering English/Spanish events #284

Merged
merged 4 commits into from
Aug 2, 2019

Conversation

jmithani
Copy link
Contributor

@jmithani jmithani commented Jul 3, 2019

Per Metro-Records/la-metro-councilmatic#393 (comment), Spanish and English events will always occur at the same time. Therefore, the keys we use to match the events are sufficient if they contain the committee name and date of meeting.

This PR removes the event time as a part of the partner_key and key.

@jmithani jmithani requested a review from hancush July 3, 2019 19:49
Copy link
Collaborator

@hancush hancush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this, @jmithani! let's hold onto this until we're back in the office on monday. feel free to rebase #245 off this, if you want to continue work there in the meantime!

lametro/events.py Outdated Show resolved Hide resolved
@jmithani jmithani requested a review from hancush July 9, 2019 16:17
lametro/events.py Outdated Show resolved Hide resolved
Co-Authored-By: Hannah Cushman <hancush@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants